Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick]Using zero serverID for metrics #31519

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

XuanYang-cn
Copy link
Contributor

Fixes: #31516
pr: #31518

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby March 22, 2024 06:21
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 22, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 22, 2024
Copy link
Contributor

mergify bot commented Mar 22, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.80%. Comparing base (9977454) to head (f82f0af).
Report is 48 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31519      +/-   ##
==========================================
- Coverage   80.89%   80.80%   -0.10%     
==========================================
  Files         980      965      -15     
  Lines      143575   136545    -7030     
==========================================
- Hits       116150   110331    -5819     
+ Misses      23540    22503    -1037     
+ Partials     3885     3711     -174     
Files Coverage Δ
internal/datanode/services.go 85.63% <100.00%> (+3.07%) ⬆️
pkg/mq/msgdispatcher/client.go 100.00% <100.00%> (ø)
internal/datanode/data_node.go 80.65% <85.71%> (+1.02%) ⬆️

... and 41 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 25, 2024
@XuanYang-cn
Copy link
Contributor Author

related to #31597

@XuanYang-cn XuanYang-cn changed the title fix: Using zero serverID for metrics fix: [cherry-pick]Using zero serverID for metrics Apr 1, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Apr 1, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3002f94 into milvus-io:2.4 Apr 2, 2024
14 checks passed
@XuanYang-cn XuanYang-cn deleted the c/fix-log-serverid branch April 7, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants